We do ask each datastore factory to check the connection parameters, but
some DataStores are unable to tell if the parameters work until they are
used. An example is a shapefile datastore, the parameters may work - and
then be invalid if the file is moved. Or a database datastore may fail in
the database is down or unavailable due to a network change.
Jody

On Tue Dec 09 2014 at 10:18:24 AM Karl-Philipp Richter <[email protected]>
wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Good question :) I'd appreciate an update of the javadocs. The
> functionality is ok, at least I have not used it long enough to
> evaluate possible improvements (one candidate would be to not allow
> retrieval of DataStore instances with invalid connection parameters).
>
> Am 12/09/2014 um 06:55 PM schrieb Jody Garnett:
> > So is this a request to update the javadocs? Or the functionality
> > ...
> >
> > I don't mind adding a few more comments to the javadoc, or the
> > associated documentation. -
> >
> >
> > On Tue Dec 09 2014 at 1:13:15 AM Karl-Philipp Richter
> > <[email protected]> wrote:
> >
> > Hi, passing errornous connection parameter to
> > DataStoreFinder.getDataStore doesn't cause the method to fail
> > (which is ok, because it
> >
> > Checks each available datasource implementation in turn and
> > returns the first one which claims to support the resource
> > identified by the params object.
> >
> > [http://docs.geotools.org/latest/javadocs/org/geotools/
> > data/DataStoreFinder.html#getDataStore%28java.util.Map%29]). It
> > would help to mention that the returned instance can fail
> > immediately when the specified connection parameters aren't valid
> > and cause a java.net.ConnectException, though. I'm currently
> > validating the connection with
> > currentDataStore.getFeatureSource(String) in a try-catch-block.
> > It'd be great if the javadoc reader would get a hint about that or
> > a better practice.
> >
> > -Kalle
> >>
> >> ------------------------------------------------------------
> >> ------------------ Download BIRT iHub F-Type - The Free
> >> Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge
> >> Your Business Reports and Dashboards with Interactivity,
> >> Sharing, Native Excel Exports, App Integration & more Get
> >> technology previously reserved for billion-dollar corporations,
> >> FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&;
> >> iu=/4140/ostg.clktrk
> >> _______________________________________________ GeoTools-Devel
> >> mailing list [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/geotools-devel
> >>
> >
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
>
> iQEcBAEBAgAGBQJUhzzkAAoJEGadKJ8eJ7ZGGJIH+wc3x25AUFx8RsxYb6FGc19g
> S8rKdYMipRtSm7S+Z029lHrFvBItS3s1PrjkjyIBs/emBQqNUy42er6ou1S22MKe
> C1qtc5L9taQvmR3rJ3mczZNsiaj7K2eTsm21iVSqZnmJ9yRh9pGFS/3gwCJeOrpC
> ILzhoTFwDj5F5A0upopPeM4ED3f02RHE4/MzcgNDnrLeCYpT64QWLkwfCd+jxu8p
> p7ygl0RjpL98iIoIjux2W8nWZnUFg/lpiGyEQx2N+M+VJ/zlGcm1c41atemMBWKQ
> dQJnCYzm0X65d8GtMtSGHqA0CTVo17TkjNHcq6YT5BmblhU8Q6Ajr3/RvalYmJw=
> =r0Wk
> -----END PGP SIGNATURE-----
>
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to