-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Good point (and reasonable implementation :) ). Some more of that in the javadocs would be good, but come on, I'll do it :) I'd just like to have a jira account if possible.
Am 12/09/2014 um 08:27 PM schrieb Jody Garnett: > We do ask each datastore factory to check the connection > parameters, but some DataStores are unable to tell if the > parameters work until they are used. An example is a shapefile > datastore, the parameters may work - and then be invalid if the > file is moved. Or a database datastore may fail in the database is > down or unavailable due to a network change. Jody > > On Tue Dec 09 2014 at 10:18:24 AM Karl-Philipp Richter > <[email protected]> wrote: > > Good question :) I'd appreciate an update of the javadocs. The > functionality is ok, at least I have not used it long enough to > evaluate possible improvements (one candidate would be to not > allow retrieval of DataStore instances with invalid connection > parameters). > > Am 12/09/2014 um 06:55 PM schrieb Jody Garnett: >>>> So is this a request to update the javadocs? Or the >>>> functionality ... >>>> >>>> I don't mind adding a few more comments to the javadoc, or >>>> the associated documentation. - >>>> >>>> >>>> On Tue Dec 09 2014 at 1:13:15 AM Karl-Philipp Richter >>>> <[email protected]> wrote: >>>> >>>> Hi, passing errornous connection parameter to >>>> DataStoreFinder.getDataStore doesn't cause the method to >>>> fail (which is ok, because it >>>> >>>> Checks each available datasource implementation in turn and >>>> returns the first one which claims to support the resource >>>> identified by the params object. >>>> >>>> [http://docs.geotools.org/latest/javadocs/org/geotools/ >>>> data/DataStoreFinder.html#getDataStore%28java.util.Map%29]). >>>> It would help to mention that the returned instance can fail >>>> immediately when the specified connection parameters aren't >>>> valid and cause a java.net.ConnectException, though. I'm >>>> currently validating the connection with >>>> currentDataStore.getFeatureSource(String) in a >>>> try-catch-block. It'd be great if the javadoc reader would >>>> get a hint about that or a better practice. >>>> >>>> -Kalle >>>>> >>>>> ------------------------------------------------------------ >>>>> >>>>> - ------------------ Download BIRT iHub F-Type - The Free >>>>> Enterprise-Grade BIRT Server from Actuate! Instantly >>>>> Supercharge Your Business Reports and Dashboards with >>>>> Interactivity, Sharing, Native Excel Exports, App >>>>> Integration & more Get technology previously reserved for >>>>> billion-dollar corporations, FREE >>>>> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&; >>>>> iu=/4140/ostg.clktrk >>>>> _______________________________________________ >>>>> GeoTools-Devel mailing list >>>>> [email protected] >>>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>>>> >>>> >> > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUh+vvAAoJEGadKJ8eJ7ZGIzYIAL3pwU6y66gBxGY1b5sBEM/9 B9doe2K5KOEwckvQAaj5bPPPse9PU5m7j5S5BDOY+o2A6efOO/J2BT3znaV+tKwP NfP3QLObknOJ3VWKDb7a1RDu0SiLCxOUZHer3/lLJSjX6DBejkJRRCMEGAkbff4B XgTPudCTieie3rXfGojoXn9rm+8YsT2N7NBs7WpLxpO8v//xRKnArLEiFHh1AXEg 1uhXu0YRJosjtHU5phvAAgfc7O1EIar+Rhn7fL1Lr7eu18ouZNXCYez2dXXyLzBi 477umve19+Z/j+WCG0vRvoaV/o51Hr6cnP6EP07RItG1DNvPuDokHjU/TQhxOPo= =1QFv -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
