Yeah definitely.

On 18-03-15 20:04, Jody Garnett wrote:
Thanks Niels/Sampo - I had an action item to review the changes but did not get to it.

I assume this change is of benefit to geoserver wfs cascade (and would like to be included in the release?)

--
Jody Garnett

On 18 March 2015 at 08:18, Niels Charlier <[email protected] <mailto:[email protected]>> wrote:

    Hello Sampo,

    Thank you for your review and your comments, I have responded to them.

    I hope we can push this commit through asap.

    Kind Regards
    Niels


    On 13-03-15 15:01, Sampo Savolainen wrote:
    Hi,

    Sorry about the radio silence. I've been working on an unrelated
    big project and I haven't had a chance to focus on this. I agree
    that the testing in wfs-ng has not been up to spec and I
    appreciate your effort in getting that house in order. I had a
    quick look and found nothing really wrong with it but I didn't
    have a chance to actually try it out. Comments are in github.

    Which version would this be included in? 13.1?


     Sampo

    On Fri, Mar 13, 2015 at 11:54 AM, Niels Charlier <[email protected]
    <mailto:[email protected]>> wrote:

        Sampo,

        Would you have the time to have a look at that? Or anyone else?

        Kind Regards
        Niels


        On 28-02-15 19:16, Niels Charlier wrote:

            Hi,

            I have a new patch ready to improve the wfs-ng tests. All
            of this was
            done with the purpose of creating test cases for the new
            WFS 2.0
            functionality.
            I thought the test directory in wfs-ng was such a
            terrible mess it
            needed serious work first.
            A summary of what happened in this commit:

               1. Removed a bunch of duplicated test support
            reference data xml files,
                  and put all of them in one single directory
            structure instead of
            being spread around.
               2. WFFTestData and DataTestSupport were almost
            duplicates from each
            other,
                  removed the older one and converted all tests to
            use the newer one.
               3. There were two separate geoserveronlinetests, one
            for wfs1.0 and
            one for both wfs1.0 and wfs1.1
                   made one abstract online test class and one
            derived test class per
            server/version combination.
               4. Enabled all of the disabled online test methods and
            made them work
            with the geoserver tests (release data dir).
               5. Enabled most of the disabled test methods in the
            integration test
            and made them work for the wfs1.1 geoserver
                  integration test case.
               6. Fixed issues with axis order implementation so the
            offline and
            online axis order tests work.
               7. Created a very clear package/directory structure
            for all tests so
            that you can very easily see
                  which server/wfs-version combinations have tests
            and which don't,
            offline and online.
               8. Renamed some confusing class names and removed
            unnecessary
            duplicated stuff
                  for example there was both a TestHttpClient and
            TestHTTPClient.
               9. Added pullparser test which tests the new parser
            (that works with
            GML3.2).

            TODO
               1. make online and offline WFS 2.0 tests. THis should
            now be rather
            easy with the existing abstract integration and online
                  test classes available which only require you to
            insert the right
            reference data info.
               2. verify the existing online tests for other servers
            than geoserver

            https://github.com/geotools/geotools/pull/757

            Regards
            Niels

            
------------------------------------------------------------------------------
            Dive into the World of Parallel Programming The Go
            Parallel Website, sponsored
            by Intel and developed in partnership with Slashdot
            Media, is your hub for all
            things parallel software development, from weekly thought
            leadership blogs to
            news, videos, case studies, tutorials and more. Take a
            look and join the
            conversation now. http://goparallel.sourceforge.net/
            _______________________________________________
            GeoTools-Devel mailing list
            [email protected]
            <mailto:[email protected]>
            https://lists.sourceforge.net/lists/listinfo/geotools-devel





-- Sampo Savolainen
    R&D Director, Spatineo Oy
    [email protected] <mailto:[email protected]>
    +358-407555649 <tel:%2B358-407555649>
    Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
    www.spatineo.com <http://www.spatineo.com>,
    twitter.com/#!/spatineo <http://twitter.com/#%21/spatineo>
    www.linkedin.com/company/spatineo-inc
    <http://www.linkedin.com/company/spatineo-inc>

    This message may contain privileged and/or confidential
    information. If you
    have received this e-mail in error or are not the intended
    recipient, you
    may not use, copy, disseminate, or distribute it; do not open any
    attachments, delete it immediately from your system and notify
    the sender
    promptly by e-mail that you have done so.


    
------------------------------------------------------------------------------
    Dive into the World of Parallel Programming The Go Parallel
    Website, sponsored
    by Intel and developed in partnership with Slashdot Media, is your
    hub for all
    things parallel software development, from weekly thought
    leadership blogs to
    news, videos, case studies, tutorials and more. Take a look and
    join the
    conversation now. http://goparallel.sourceforge.net/
    _______________________________________________
    GeoTools-Devel mailing list
    [email protected]
    <mailto:[email protected]>
    https://lists.sourceforge.net/lists/listinfo/geotools-devel



------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to