Oh, much breakage: https://osgeo-org.atlassian.net/browse/GEOT-5047 https://github.com/geotools/geotools/pull/858
Breaks online tests for gt-jdbc-oracle and gt-jdbc-sqlserver on Boundless Jenkins: http://ares.boundlessgeo.com/jenkins/view/geotools/job/geotools-master-online/134/consoleText Breaks gt-jdbc-postgis for me locally against postgres 9.4 / postgis 2.1: PostgisUDTOnlineTest>OnlineTestCase.run:123->testRead:81 expected:<2004-10-30 1[7]:30:00.0> but was:<2004-10-30 1[8]:30:00.0> org.geotools.data.postgis.PostgisUDTOnlineTest passes when run by itself in Maven or Eclipse. Leaky fixture? All tests in (ps and non-ps) PostgisTemporalFilterOnlineTest fail in Eclipse when all tests for the module are run. They pass when run individually. No breakage in GeoServer app-schema online tests against postgis. Kind regards, Ben. On 28/05/15 20:27, Ian Turton wrote: > Currently the only place I know that changes them at runtime is in the new > test :-) > > Good catch on the static DateFormaters - I remember being bitten by that in > the past, now. I'll refactor that out this morning. > > Ian > > On Thu, May 28, 2015 at 9:23 AM Andrea Aime <andrea.a...@geo-solutions.it> > wrote: > >> Hi Ian, >> sorry I could not review in time, but it looks good. Curious about the >> timezone changing at runtime, which software does that? >> >> Actually wait a second, that section of code is buggy in another way, one >> cannot have statically cached date formatters, they are not >> thread safe... >> >> Cheers >> Andrea >> >> On Thu, May 28, 2015 at 10:18 AM, Ian Turton <ijtur...@gmail.com> wrote: >> >>> I've fixed my local build now and tested a local GeoServer build against >>> it too. So I've gone a head and merged. >>> >>> Ian >>> >>> On Tue, May 26, 2015 at 5:59 PM Ian Turton <ijtur...@gmail.com> wrote: >>> >>>> There is now a PR that should solve this problem - >>>> https://github.com/geotools/geotools/pull/858 I'm waiting on Travis as >>>> my mchine is (wierdly) refusing to build either my branch or master due >>>> to missing Assertions in gt-coverage . So if someone else can check it and >>>> merge that would be great. >>>> >>>> >>>> Ian >>>> >>>> On Sat, May 16, 2015 at 7:26 PM Ian Turton <ijtur...@gmail.com> wrote: >>>> >>>>> Not yet but now I'm at loose end and back on the Internet at the >>>>> weekend I should have a good chance to fix it next week. >>>>> >>>>> Ian >>>>> >>>>> On Sat, 16 May 2015 6:04 pm Andrea Aime <andrea.a...@geo-solutions.it> >>>>> wrote: >>>>> >>>>>> On Sun, Apr 19, 2015 at 4:06 PM, Ian Turton <ijtur...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> That all makes a lot of sense, I was never clear on why we coerced >>>>>>> them into GMT. >>>>>>> >>>>>>> That leaves the JDBC date test case - I think that if we stop forcing >>>>>>> dates into GMT then it will go back to working east of Greenwich as the >>>>>>> DB >>>>>>> will be created in the local time zone - I'll try and have a look this >>>>>>> week. >>>>>>> >>>>>> >>>>>> Hi Ian, >>>>>> did you ever make progress on this one? >>>>>> >>>>>> Cheers >>>>>> Andrea >>>>>> >>>>>> -- >>>>>> == >>>>>> GeoServer Professional Services from the experts! Visit >>>>>> http://goo.gl/NWWaa2 for more information. >>>>>> == >>>>>> >>>>>> Ing. Andrea Aime >>>>>> @geowolf >>>>>> Technical Lead >>>>>> >>>>>> GeoSolutions S.A.S. >>>>>> Via Poggio alle Viti 1187 >>>>>> 55054 Massarosa (LU) >>>>>> Italy >>>>>> phone: +39 0584 962313 >>>>>> fax: +39 0584 1660272 >>>>>> mob: +39 339 8844549 >>>>>> >>>>>> http://www.geo-solutions.it >>>>>> http://twitter.com/geosolutions_it >>>>>> >>>>>> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* >>>>>> >>>>>> Le informazioni contenute in questo messaggio di posta elettronica e/o >>>>>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il >>>>>> loro utilizzo è consentito esclusivamente al destinatario del messaggio, >>>>>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo >>>>>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di >>>>>> darcene notizia via e-mail e di procedere alla distruzione del messaggio >>>>>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, >>>>>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od >>>>>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai >>>>>> principi dettati dal D.Lgs. 196/2003. >>>>>> >>>>>> >>>>>> >>>>>> The information in this message and/or attachments, is intended solely >>>>>> for the attention and use of the named addressee(s) and may be >>>>>> confidential >>>>>> or proprietary in nature or covered by the provisions of privacy act >>>>>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection >>>>>> Code).Any use not in accord with its purpose, any disclosure, >>>>>> reproduction, >>>>>> copying, distribution, or either dissemination, either whole or partial, >>>>>> is >>>>>> strictly forbidden except previous formal approval of the named >>>>>> addressee(s). If you are not the intended recipient, please contact >>>>>> immediately the sender by telephone, fax or e-mail and delete the >>>>>> information in this message that has been received in error. The sender >>>>>> does not give any warranty or accept liability as the content, accuracy >>>>>> or >>>>>> completeness of sent messages and accepts no responsibility for changes >>>>>> made after they were sent or for other risks which arise as a result of >>>>>> e-mail transmission, viruses, etc. >>>>>> >>>>>> ------------------------------------------------------- >>>>>> >>>>> >> >> >> -- >> == >> Meet us at the INSPIRE Conference in Lisbon 25-29 May 2015! Visit >> http://goo.gl/WHKDXT for more information. >> == >> >> Ing. Andrea Aime >> @geowolf >> Technical Lead >> >> GeoSolutions S.A.S. >> Via Poggio alle Viti 1187 >> 55054 Massarosa (LU) >> Italy >> phone: +39 0584 962313 >> fax: +39 0584 1660272 >> mob: +39 339 8844549 >> >> http://www.geo-solutions.it >> http://twitter.com/geosolutions_it >> >> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* >> >> Le informazioni contenute in questo messaggio di posta elettronica e/o >> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il >> loro utilizzo è consentito esclusivamente al destinatario del messaggio, >> per le finalità indicate nel messaggio stesso. Qualora riceviate questo >> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di >> darcene notizia via e-mail e di procedere alla distruzione del messaggio >> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, >> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od >> utilizzarlo per finalità diverse, costituisce comportamento contrario ai >> principi dettati dal D.Lgs. 196/2003. >> >> >> >> The information in this message and/or attachments, is intended solely for >> the attention and use of the named addressee(s) and may be confidential or >> proprietary in nature or covered by the provisions of privacy act >> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection >> Code).Any use not in accord with its purpose, any disclosure, reproduction, >> copying, distribution, or either dissemination, either whole or partial, is >> strictly forbidden except previous formal approval of the named >> addressee(s). If you are not the intended recipient, please contact >> immediately the sender by telephone, fax or e-mail and delete the >> information in this message that has been received in error. The sender >> does not give any warranty or accept liability as the content, accuracy or >> completeness of sent messages and accepts no responsibility for changes >> made after they were sent or for other risks which arise as a result of >> e-mail transmission, viruses, etc. >> >> ------------------------------------------------------- >> > > > > ------------------------------------------------------------------------------ > > > > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <http://transient.nz/> New Zealand ------------------------------------------------------------------------------ _______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
