As you two are the only active developers with a mongodb environment (and this is an unsupported module) you may wish to relax about fixing test cases (and commit directly) - and save pull requests for when you have a functionality change and want to solicit feedback.
Rather than watch this conversation stretch out across the timezones I am going to merge your work in, resolving conflicts as I go - and ask you both to review/test the result :) -- Jody Garnett On 16 June 2015 at 01:39, Stefano Costa <stefano.co...@geo-solutions.it> wrote: > Hi Torben, > > Il giorno lun, 15/06/2015 alle 15.33 -0700, Torben Barsballe ha scritto: > > Hello, > > > > > > I have made some fixes to the MongoDB plugin - see > > https://github.com/geotools/geotools/pull/880 > > > > > > The main fix deals with an issue where indexes on array values make it > > impossible to import data from MongoDB into GeoServer (See > > https://github.com/boundlessgeo/geoserver-exts/issues/83 ). > > > > > > As part of this, I have also fixed a number of failing test cases. > > As pointed out by Andrea, it seems we both fixed the same code. Looks > like our code regarding test case fixes is 99% identical, but yours is > isolated in a single commit: > > https://github.com/tbarsballe/geotools/commit/4f37e60e05766a177581895fd68648504c5a86d9 > > If that's ok with you, I propose you remove that commit from your PR and > I incorporate what's missing from your code into my PR. Then, an update > to your third commit, "Added test for indexed list", will likely be > needed after my PR is merged, but that should be all. > > What do you think? > > > > > > > Tom/Stefano - I have heard you have some experience with the MongoDB > > plugin, might you be able to review my PR? > > I've just started working on it, so I'm by all means no authority on the > subject :-) > > I will have a look at your code and see if I can come up with useful > advice. > > > > > > > Thanks, > > > > Torben Barsballe > > > > > > > > -- > > Best regards, > Stefano Costa > > == > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. > == > Dott. Stefano Costa > Senior Software Engineer > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. > Il loro utilizzo è consentito esclusivamente al destinatario del > messaggio, per le finalità indicate nel messaggio stesso. Qualora > riceviate questo messaggio senza esserne il destinatario, Vi preghiamo > cortesemente di darcene notizia via e-mail e di procedere alla > distruzione del messaggio stesso, cancellandolo dal Vostro sistema. > Conservare il messaggio stesso, divulgarlo anche in parte, > distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità > diverse, costituisce comportamento contrario ai principi dettati dal > D.Lgs. 196/2003. > > The information in this message and/or attachments, is intended solely > for the attention and use of the named addressee(s) and may be > confidential or proprietary in nature or covered by the provisions of > privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New > Data Protection Code).Any use not in accord with its purpose, any > disclosure, reproduction, copying, distribution, or either > dissemination, either whole or partial, is strictly forbidden except > previous formal approval of the named addressee(s). If you are not the > intended recipient, please contact immediately the sender by > telephone, fax or e-mail and delete the information in this message > that has been received in error. The sender does not give any warranty > or accept liability as the content, accuracy or completeness of sent > messages and accepts no responsibility for changes made after they > were sent or for other risks which arise as a result of e-mail > transmission, viruses, etc. > > > > > > ------------------------------------------------------------------------------ > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel >
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
