Hi Jody, thanks for taking the time to review and merge! Il giorno mar, 16/06/2015 alle 09.48 -0700, Jody Garnett ha scritto: > Ran into a couple issues with both pull requests.
> Stefano: > - the getCountInternal method should return -1 (rather than a full > table scan). Sorry if the javadocs were not clear. Sorry about that, I overlooked the Javadoc on FeatureSource.getCount() and went straight to reproducing the behavior of JDBCFeatureSource.getCountInternal(). So I guess in that case a full table scan when a postFilter is present was judged acceptable. > - The instance of check to ensure LikeFilter is only encoded with > PropertyName is only half the story, the other teaching the pre post > filter visitor logic about this requirement. I have hacked up an > example (to show what I mean) but the code should be migrated from the > deprecated PostPreProcessFilterSplittingVisitor > to CapabilitiesFilterSplitter to consider this fixed. > I missed that, thanks for the example. > > Please update and test, thanks to both of you for the work :) > I did and works for me, after a small fix to a unit test: https://github.com/geotools/geotools/pull/883 > -- > Jody Garnett -- Best regards, Stefano Costa == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Dott. Stefano Costa Senior Software Engineer GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. ------------------------------------------------------------------------------ _______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
