Added my +1, got a couple questions/clarifications. *ContrastMethod*
The proposal has been implemented in such a way that existing code will > compile without change. One item to note is that `ContrastMethod.NORMALIZE` > and `ContrastMethod.HISTOGRAM` are no longer enums but are now Strings. That sentence seems indicates a break with API compatibility. Should this change from an Enum to a CodeList (if the requirement is to add more options at runtime while still retaining type safety). This would be less of a break than changing to a String, indeed client code may not need to be recompiled. I ask as changing some of these string constants to Enums gave a lot of trouble when migrating from geotools style to geoapi style. And I do not want to repeat the experience. *Tasks* The tasks section is just boiler plate, I am always interested in making sure we do not miss anything (interface/implementation/tests/docs/update instructions) and confirm resourcing needs are met or we need to ask for a volunteer. In this case are you comfortable writing a documentation example or do you need me to volunteer. -- Jody Garnett On 4 August 2015 at 06:45, Ian Turton <[email protected]> wrote: > > In conjunction with GeoSolutions I've written a proposal for the > implementation of the changes needed to make Contrast Enhancement work with > specified algorithms and parameters rather than just doing it as a black > box as currently. > > The proposal is at > https://github.com/geotools/geotools/wiki/Extend-Contrast-Enhancement-method-handling-in-SLD-and-CSS > (and is in partnership with GEOT-5180). > > Cheers > > Ian > > -- > Ian Turton > > > ------------------------------------------------------------------------------ > > _______________________________________________ > GeoTools-Devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > >
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
