A couple bits of feedback...
To confirm, ClipToMinimumMaximum is a normalization algorithm, and not an
alternative ContrastEnhancement.getType() ? Like I would only expect it to
work if ContrastEnhancement.getType() is NORMALIZE ...
For CSS all vendor options follow the same approach with -gt- prefixes, so
your example should be something like.
* {
raster-channels: auto;
raster-contrast-enhancement: normalize;
-gt-raster-contrast-enhancement-algorithm: ClipToMinimumMaximum;
-gt-raster-contrast-enhancement-parameter: minValue 20 maxValue 30;
raster-gamma : 0.5;
raster-color-map: color-map-entry(#008000, 70)
color-map-entry(#663333, 256);
raster-gamma: 0.5;
}
The parameter definition looks a bit funny, but is consistent with
label-anchor: 0.5 0.5. I guess all the other vendor options get their own
definition for something like:
* {
raster-channels: auto;
raster-contrast-enhancement: normalize;
-gt-raster-contrast-enhancement-algorithm: ClipToMinimumMaximum;
-gt-raster-contrast-enhancement-min: 20
-gt-raster-contrast-enhancement-max: 30;
raster-gamma : 0.5;
raster-color-map: color-map-entry(#008000, 70)
color-map-entry(#663333, 256);
raster-gamma: 0.5;
}
I no longer see the API Change section in the proposal? Think you were at
least looking at a getOptions(): Map<String,Expression> method?
--
Jody Garnett
On 6 August 2015 at 12:22, ian <[email protected]> wrote:
>
>
> On Wed, 5 Aug, 2015 at 5:50 PM, ian <[email protected]> wrote:
>
>
>
> On Wed, 5 Aug, 2015 at 5:27 PM, Jody Garnett <[email protected]>
> wrote:
>
> There is a really different track here on how to modify the style
> interfaces in a safe manner (between this proposals and anime's. I made the
> suggestion for FeatureTypeStyle.getSortBy() ... and the answer was to
> consistently use the vendor options parameter map. Down a few levels here
> to RasterSymbolizer and we have this proposal that is far more invasive.
>
> Can we try for a middle ground ... can RasterSymbolizer make use of vendor
> options for this functionality? At least the getParameters() is acting like
> RasterSymbolizer.getOptions().
>
>
> OK after a quick chat with Jody (which must have been really early for
> him, so thanks for getting up now). I'm going to go with a plan to use
> Vendor Options for this which is almost certainly a better way of doing it
> for interoperability.
>
> This will change the proposal a bit and I'll hack on it later to reflect
> the changes I actually make.
>
> The plan is to use the existing (but deprecated) getType() in
> ContrastEnhancement to store a string or a code list ContrastMethod which
> will alert users of the class to go check for options like algorithm and
> parameters when they come to do some enhancement work.
>
>
> Just to let people know that we've updated the proposal and issued an
> initial PR to let people see what's changing.
>
> We plan to finish off Documentation, formatting and other tidying up
> tomorrow European time, with an aim to merge before Daniele goes off on
> holiday at the end of the day.
>
> Please review and comment at https://github.com/geotools/geotools/pull/925
>
> Cheers
>
> Ian
>
>
------------------------------------------------------------------------------
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
