Thanks Ben for your prompt and valuable feedback! I updated the PR according to your suggestion.
About the use of a system property, I'm still unsure whether in the end we'll want to remove it: if the performance overhead proves negligible, we would make it default, but if the performance overhead proves significant, there might still be situations where enabling it could be the only way to make sure all definitions from external schemas are correctly imported (e.g. a schema imports 2 other schemas, but contains elements / types related only to the first schema: I believe in this case the second schema will not be imported, unless a forced import is triggered). Should I turn it into a Hint? On Tue, Aug 25, 2015 at 8:34 AM, Jody Garnett <jody.garn...@gmail.com> wrote: > The use of System setProperty has evolved into our preferred way of > soft-enabling a change of functionality (while allowing for backwards > compatibility .. which is eventually removed). > > By contrast Hints (like for Query or StreamingRenderer) should be used to > for configuration / dependency injection (and ends up as documented API). > > So the difference, if the functionality planned to be removed/replaced use > System property, if it is a configuration option that we are going to > commit to long term use hints: > > > > -- > Jody Garnett > > On 24 August 2015 at 18:15, Ben Caradoc-Davies <b...@transient.nz> wrote: > >> Stefano, >> >> I can confirm that, with PR 946 (your fix-GEOT-5194 branch), a full build >> of GT + GWC + GS + GS-app-schema-online-tests-against-postgis passes. >> (gt-jdbc-postgis online tests disabled because of GEOT-5197.) >> https://github.com/geotools/geotools/pull/946 >> >> I made one suggestion: add the System.setProperty statement to >> SchemasTest.tearDown to improve fixture hygiene. With this improvement, I >> am comfortable for your change be merged on master before the freeze. >> >> Jody, is this use of System.setProperty acceptable or should Hints be >> used? >> >> Kind regards, >> Ben. >> >> >> On 25/08/15 09:47, Stefano Costa wrote: >> >>> Hi Ben, >>> thanks for answering. >>> >>> Let me know if there is anything I can do to have this merged before the >>> feature freeze. I won't be available on the 27th nor the 28th, though. >>> >>> On Mon, Aug 24, 2015 at 11:25 PM, Ben Caradoc-Davies <b...@transient.nz> >>> wrote: >>> >>> And we certainly want a full GeoServer app-schema online test run before >>>> any merges are contemplated. >>>> >>>> On 25/08/15 09:23, Ben Caradoc-Davies wrote: >>>> >>>> Thanks, Jody. I hope to give this issue some attention later this week >>>>> or early next. >>>>> >>>>> >>>> -- >>>> Ben Caradoc-Davies <b...@transient.nz> >>>> Director >>>> Transient Software Limited <http://transient.nz/> >>>> New Zealand >>>> >>>> >>> >>> >>> >> -- >> Ben Caradoc-Davies <b...@transient.nz> >> Director >> Transient Software Limited <http://transient.nz/> >> New Zealand >> > > -- Best regards, Stefano Costa == GeoServer Professional Services from the experts! Visithttp://goo.gl/it488V for more information. == Dott. Stefano Costa Senior Software Engineer GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.ithttp://twitter.com/geosolutions_it ------------------------------------------------------- AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
