Stefano,

I can confirm that, with PR 946 (your fix-GEOT-5194 branch), a full 
build of GT + GWC + GS + GS-app-schema-online-tests-against-postgis 
passes. (gt-jdbc-postgis online tests disabled because of GEOT-5197.)
https://github.com/geotools/geotools/pull/946

I made one suggestion: add the System.setProperty statement to 
SchemasTest.tearDown to improve fixture hygiene. With this improvement, 
I am comfortable for your change be merged on master before the freeze.

Jody, is this use of System.setProperty acceptable or should Hints be used?

Kind regards,
Ben.

On 25/08/15 09:47, Stefano Costa wrote:
> Hi Ben,
> thanks for answering.
>
> Let me know if there is anything I can do to have this merged before the
> feature freeze. I won't be available on the 27th nor the 28th, though.
>
> On Mon, Aug 24, 2015 at 11:25 PM, Ben Caradoc-Davies <b...@transient.nz>
> wrote:
>
>> And we certainly want a full GeoServer app-schema online test run before
>> any merges are contemplated.
>>
>> On 25/08/15 09:23, Ben Caradoc-Davies wrote:
>>
>>> Thanks, Jody. I hope to give this issue some attention later this week
>>> or early next.
>>>
>>
>> --
>> Ben Caradoc-Davies <b...@transient.nz>
>> Director
>> Transient Software Limited <http://transient.nz/>
>> New Zealand
>>
>
>
>

-- 
Ben Caradoc-Davies <b...@transient.nz>
Director
Transient Software Limited <http://transient.nz/>
New Zealand

------------------------------------------------------------------------------
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to