2015-09-09 8:27 GMT+02:00 Andrea Aime <[email protected]>:
> On Tue, Sep 8, 2015 at 11:02 PM, Jody Garnett <[email protected]>
> wrote:
>
>> Pull request is good, in today's GeoTools meeting we discussed the issue.
>> Apparently LinkedHashMap was used to preserve order (making test cases
>> easier).
>>
>
> The main issue is that the memory data store has never been meant to be a
> production store, Jody pointed out in the past
> that is was setup for tests and to provide correct reference behavior, and
> that we should probably not make it too complicated.
> Things change over time, so maybe this is an occasion to turn it from
> reference behavior to production usage?
>
> Ideally, it would be best to use concurrent structures inside the store
> and fix the order dependent tests instead.
>
At the moment two tests are failing:
* MemoryDataStoreTest.testOrderPreservationMemFetures
* MemoryDataStoreTest.testOrderPreservationRoad
Since its not an "Ordered" DataStore that should preserve order I'd suggest
to remove these tests. Opinions?
> Some sort of indexing in the store would also be nice, many people asked
> for spatially indexed memory structures
> for faster rendering, I did a read only mockup in the past, insisting that
> it's just an example, but I believe
> someone added to the code base a simplified version of it... yeah,
> see SpatialIndexFeatureSource in gt-main.
>
>
Are you sure about the class. I had SpatialIndexFeatureCollection in mind
that has a STRtree index internally. What about replacing the
ConcurrentHashMap (was LinkedHasMap) with SpatialIndexFeatureCollection?
the Method
protected Map<String,SimpleFeature> features(String typeName) throws
IOException
is only used in MemoryDataStoreReader/Writer and not a public interface ->
no API change. Only Test-classes needs an update.
I'm wondering how you would think about this "proposal". However, STRtree
internal creates a new List every type the Index is requested. I haven't
investigated thread savety of STRtree yet. Maybe anybody of you has much
more experiance than me to give feedback on that
Cheers
Frank
> Cheers
> Andrea
>
>
> --
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
>
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
> -------------------------------------------------------
>
------------------------------------------------------------------------------
Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
