Hello folks, I updated the initial pull request. Additional to the internal ConcurrentSkipListMap usage I synched the access to internal HashMaps (memory & schema objects) to avoid issues with concurrent access (createSchema, removeSchema (see pull https://github.com/geotools/geotools/pull/1022) and addFeatures and features() methodes)
Do you have any comments or requests for change on the outstanding pull request https://github.com/geotools/geotools/pull/1002 Hope anybody of you can have a look at while I start working on the pull to backport it into 14.x Thanks a lot - Frank 2015-09-13 9:09 GMT+02:00 Andrea Aime <[email protected]>: > On Thu, Sep 10, 2015 at 11:13 PM, Jody Garnett <[email protected]> > wrote: > >> Since its not an "Ordered" DataStore that should preserve order I'd >>> suggest to remove these tests. Opinions? >>> >> >> If you change the functionality, change the test to match. There should >> now be several feature collection implementations to choose from so code >> that requires a TreeSet based functionality has a migration path. >> >> I'm wondering how you would think about this "proposal". However, STRtree >>> internal creates a new List every type the Index is requested. I haven't >>> investigated thread savety of STRtree yet. Maybe anybody of you has much >>> more experiance than me to give feedback on that >>> >> >> The index needs to get rebuilt each time a feature is modified, so other >> than that overhead (which could be pushed off until "commit" ) it should be >> workable. The List should not be a problem, as it offers you a bit of >> independence (at the cost of possibly traversing through out of date >> information). >> >> > One coud use a quadtree index instead, it can be modified without > rebuilding it, but it's more prone to degeration to linked list, > the STRTree is packed and optimized for balancing, but as you say, it's a > pain if stuff gets modified. > I don't think any of the JTS indexes is thread safe. > > Cheers > Andrea > > -- > == > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* > > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il > loro utilizzo è consentito esclusivamente al destinatario del messaggio, > per le finalità indicate nel messaggio stesso. Qualora riceviate questo > messaggio senza esserne il destinatario, Vi preghiamo cortesemente di > darcene notizia via e-mail e di procedere alla distruzione del messaggio > stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, > divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od > utilizzarlo per finalità diverse, costituisce comportamento contrario ai > principi dettati dal D.Lgs. 196/2003. > > > > The information in this message and/or attachments, is intended solely for > the attention and use of the named addressee(s) and may be confidential or > proprietary in nature or covered by the provisions of privacy act > (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection > Code).Any use not in accord with its purpose, any disclosure, reproduction, > copying, distribution, or either dissemination, either whole or partial, is > strictly forbidden except previous formal approval of the named > addressee(s). If you are not the intended recipient, please contact > immediately the sender by telephone, fax or e-mail and delete the > information in this message that has been received in error. The sender > does not give any warranty or accept liability as the content, accuracy or > completeness of sent messages and accepts no responsibility for changes > made after they were sent or for other risks which arise as a result of > e-mail transmission, viruses, etc. > > ------------------------------------------------------- >
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
