Thanks folks for all of the feedback. Since I got a majority of positive
votes I went ahead and merged the code and closed out the proposal.
On Thu, Feb 16, 2017 at 1:20 PM Ben Caradoc-Davies <b...@transient.nz> wrote:
> Justin,
>
> I am comfortable with either option, so implementer choice.
>
> The origin of the term "gt2" is slowly being lost in the mists of time.
> We have already dropped the "2." from the front of our versions. :-)
>
> Kind regards,
> Ben.
>
> On 16/02/17 16:18, Justin Deoliveira wrote:
> > Thanks Ben! As mentioned on the pull request I was following the only
> other
> > system property for jdbc I found: “gt2.jdbc.trace”. I do prefer your
> > suggestion aesthetically but I think I would stick with the consistency
> if
> > it were my call. But if folks feel strongly about it happy to change it
> as
> > well, no strong preference. We could also potentially rename the trace
> > property to “geotools.jdbc.trace” so that everyone wins :) … but not sure
> > how strongly people feel we have to maintain backward compatibility with
> > that.
> >
> > On Wed, Feb 15, 2017 at 7:03 PM Ben Caradoc-Davies <b...@transient.nz>
> wrote:
> >
> >> +1.
> >>
> >> My only comment is that the system property could perhaps be called
> >> "geotools.jdbc.callback" rather than "gt2.jdbc.callback".
> >>
> >> Kind regards,
> >> Ben.
> >>
> >> On 16/02/17 03:32, Justin Deoliveira wrote:
> >>> Thanks to everyone who submitted feedback on the idea, I’ve
> incorporated
> >> it
> >>> into the proposal and I would like to call for a formal vote.
> >>>
> >>> https://github.com/geotools/geotools/wiki/JDBC-Callbacks
> >>>
> >>> Thanks!
> >>>
> >>> -Justin
> >>>
> >>>
> >>>
> >>>
> >>
> ------------------------------------------------------------------------------
> >>> Check out the vibrant tech community on one of the world's most
> >>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> >>>
> >>>
> >>>
> >>> _______________________________________________
> >>> GeoTools-Devel mailing list
> >>> GeoTools-Devel@lists.sourceforge.net
> >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
> >>>
> >>
> >> --
> >> Ben Caradoc-Davies <b...@transient.nz>
> >> Director
> >> Transient Software Limited <http://transient.nz/>
> >> New Zealand
> >>
> >
>
> --
> Ben Caradoc-Davies <b...@transient.nz>
> Director
> Transient Software Limited <http://transient.nz/>
> New Zealand
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
