Hi,
I'm writing some code that is building complex features out of simple ones
(not using
app-schema for many reasons, I don't have a target schema, need good
performance, need
some limited writing support).

The facilities to deal with complex features are... rather primitives in
general.
In the particular case of this mail, I've been fighting against adding a
property that happens
to be a nested simple feature. The AttributeBuilder ends up in this block
of code:

https://github.com/geotools/geotools/blob/master/modules/library/main/src/main/java/org/geotools/feature/AttributeBuilder.java#L507

Questions:

   - If the target type is a simple feature, wouldn't it be best to build a
   simple feature?
   - Why force a collection of values, if the user called the builder
   passing the "value" of this property as an already built simple feature of
   the right type, why greet him/her with a class cast exception?

Do you see issues in making these changes?

I'm running against a deadline so in the meantime I'm work-arounding by
using complex features and the extra
Property indirection complexity (that I don't really need), but I have been
bitten so many times that I'd rather
start fixing things on a side, even if it's small bits

Cheers
Andrea

-- 

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility  for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to