Hi Roar, I think no one has picked up this review, right? If that's the case, let me suggest an approach that should be acceptable without requiring extra people to chime in:
- Check out master, run the wfs-ng tests with "-Ponline" activated, e.g., "mvn clean install -Ponline". Note down which tests are failing (there are none in my local build, but I'd still suggest you do it on your end as well) - Check out the gt-http branch, do the same, make sure there are no regression Cheeers Andrea On Tue, Jan 12, 2021 at 10:17 AM Roar Brænden <roar.brenden...@gmail.com> wrote: > Hi Andrea, > > You have a point about my changes in the tests for gt-wfs-ng. I got a > little bit carried away by changing the way TestWFSClient are created. I do > believe that I haven't changed any fundamentally, and the tests runs > successfully. It could perhaps be a point that someone with knowledge to > gt-wfs-ng takes a look at the code. > > Regards, > Roar Brænden > > 12. jan. 2021 kl. 09:56 skrev Andrea Aime <andrea.a...@geo-solutions.it>: > > Hi all, > Roar applied the feedback received so far. Wondering if the proposal needs > any update as a consequence? (does not look like, but want to be sure) > https://github.com/geotools/geotools/wiki/HTTPClient-Factory > > Also, the PR changes lots of files, but the majority are package changes > for the http client in usage points, and file moves (so it's not as hard > to review as it might seem). Do we want other reviewers to have a look? > > Cheers > Andrea > > > On Mon, Jan 4, 2021 at 9:51 PM Jody Garnett <jody.garn...@gmail.com> > wrote: > >> I outlined the proposal here >> https://github.com/geotools/geotools/wiki/HTTPClient-Factory >> >> I will ask for a review in tomorrow's meeting and trust we can get this >> done ahead of the next release. >> -- >> Jody Garnett >> >> >> On Wed, 23 Dec 2020 at 16:15, Roar Brænden <roar.brenden...@gmail.com> >> wrote: >> >>> Hi, >>> >>> I'm aware that you have a way of doing things, and that my approach >>> wasn't in accordance with that. The history is that I worked with >>> gt-tile-client this autumn and tried to make it work in parallel while >>> fetching tiles. While looking at this I saw that all too many classes of >>> Geotools take HTTPClient as an argument for the constructor, rather than >>> using a factory pattern. And that's strange cause elsewhere you are using >>> factory patterns a lot. >>> >>> >>> > 23. des. 2020 kl. 23:46 skrev Jody Garnett <jody.garn...@gmail.com>: >>> > >>> > Roar: >>> > >>> > As you may have noticed in the meeting notes your HTTPClient ideas >>> were discussed. As it has grown in the telling I agreed to write this up as >>> a proposal for the community (it is how we do design documents and make >>> sure everyone is in agreement on "big" or "impactful" changes. >>> > >>> > Before I get going what is your feeling between "gt-http" and "gt-web"? >>> > -- >>> >>> >>> I would prefer to use http, as web is too wide. >>> For the moment I have these two projects in the file structure: >>> >>> library / http (gt-http) >>> plugin / http-commons (gt-http-commons) >>> >>> >>> Regards >>> >>> Roar Brænden >> >> _______________________________________________ >> GeoTools-Devel mailing list >> GeoTools-Devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> > > > -- > Regards, Andrea Aime > == GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf > Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa > (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 > http://www.geo-solutions.it http://twitter.com/geosolutions_it > ------------------------------------------------------- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* > > > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
