On 06-05-2021 10:55, Matthijs Laan via GeoTools-Devel wrote:

The internal StAX GML parser from the wfs-ng module would be useful as a public API as it is much simpler and faster than the GTXML parsers, although the latter supports more GML elements.

Beside the GTXML parsers there is also a SAX GML parser in gt-xml, package org.geotools.gml.

Would it be a good idea to move the XmlSimpleFeatureParser.parseGeom() method to the gt-xml module in a package like org.geotools.gml.stream, or better to create a new module like modules/unsupported/gml-streaming?

Moving it to gt-xml would mean no dependencies would change for wfs-ng.
On the other hand gt-xml also contains a SAX based SLD parser but a StAX SLD parser is in a separate ysld module.

In addition to making it a public API, it is also a good opportunity to reduce code duplication in XmlSimpleFeatureParser and XmlComplexFeatureParser. The latter descends from XmlFeatureParser which has duplicated parseGeom() methods which have already diverged because in GEOT-6835 / #3393 MultiCurve support was added to one but not the other. Some more GML support for Arcs etc. could also be added.

Either way is a simple tasks moving some code around, I can make a PR for it.


+1 for pulling it up into gt-xml
-M


_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to