Hi Mark, I agree with the sentiment in general, that code has been left there rotting, making it more visible might spur some interest in it. However there lies the issue... it's getting moved from a module that's officially unsupported, to one that is, and while it's still incomplete in functionality.
I think we first need to sort out the maintenance of it. If Matthijs Laan wants to be the maintainer of it, then it can be moved, otherwise it makes little sense to do so. And if he does, he should speak to what level he intends to do so. If he's gonna bring it functionally on par with the rest of GML parsers, then it can belong to gt-xml, otherwise it's probably best if it stays in unsupported, in its own module. Just my 2 cents... Cheers Andrea On Fri, May 7, 2021 at 2:33 PM Mark Prins <mc.pr...@gmail.com> wrote: > On 06-05-2021 10:55, Matthijs Laan via GeoTools-Devel wrote: > > > > The internal StAX GML parser from the wfs-ng module would be useful as a > > public API as it is much simpler and faster than the GTXML parsers, > > although the latter supports more GML elements. > > > > Beside the GTXML parsers there is also a SAX GML parser in gt-xml, > > package org.geotools.gml. > > > > Would it be a good idea to move the XmlSimpleFeatureParser.parseGeom() > > method to the gt-xml module in a package like org.geotools.gml.stream, > > or better to create a new module like modules/unsupported/gml-streaming? > > > > Moving it to gt-xml would mean no dependencies would change for wfs-ng. > > On the other hand gt-xml also contains a SAX based SLD parser but a StAX > > SLD parser is in a separate ysld module. > > > > In addition to making it a public API, it is also a good opportunity to > > reduce code duplication in XmlSimpleFeatureParser and > > XmlComplexFeatureParser. The latter descends from XmlFeatureParser which > > has duplicated parseGeom() methods which have already diverged because > > in GEOT-6835 / #3393 MultiCurve support was added to one but not the > > other. Some more GML support for Arcs etc. could also be added. > > > > Either way is a simple tasks moving some code around, I can make a PR > > for it. > > > > +1 for pulling it up into gt-xml > -M > > > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
