Hi, OK, thanks - great that you are so open for this contribution, much appreciated. GitHub invite for sweco-semara received and accepted.
Good idea to update docs, I will prepare the PR against main with a log warning and documentation update re. deprecation of the module. Then you can all comment on the PR if you want to make some adjustments. (Heads-up: It might take some time to prepare the PR since this is done a bit in-between things at work...) :-) BR, Martin Från: Jody Garnett <jody.garn...@gmail.com> Skickat: den 4 juni 2021 02:08 Till: Kalén, Martin <martin.ka...@sweco.se> Kopia: andrea.a...@geo-solutions.it; geotools-devel@lists.sourceforge.net Ämne: Re: [Geotools-devel] Extended life for s3-geotiff in GeoServer, EHCache dependency upgrade Martin: Thanks, that sounds great. I have sent you an invitation, we appreciate you taking part directly :) As for depreciation, there is no general pattern to follow - perhaps it would be kind to put a note on the documentation page. -- Jody Garnett On Wed, 2 Jun 2021 at 06:52, Kalén, Martin <martin.ka...@sweco.se<mailto:martin.ka...@sweco.se>> wrote: Hi, Thanks for prompt replies. OK, I will re-structure a PR against main for backporting. It would be a two-step process of fist getting EHCache dependency in order in GeoTools and then propagating to GeoServer. I checked the linked GeoServer Community Modules / developers guide and yes, it sounds OK to maintain s3-geotiff for a transitioning period. You can still put in on your shortlist for future decommissioning and maybe there’s a way to clearly mark it for deprecation? Should I add e.g. a log warning regarding this – is there any module deprecation pattern to copy from some other module or historic Git commit? My GitHub id is: sweco-semara (I would still ask someone to “glance over” PR reviews, if possible – even if no other maintainer could do a formal review). Best regards, Martin Från: Andrea Aime <andrea.a...@geo-solutions.it<mailto:andrea.a...@geo-solutions.it>> Skickat: den 31 maj 2021 09:47 Till: Jody Garnett <jody.garn...@gmail.com<mailto:jody.garn...@gmail.com>> Kopia: Kalén, Martin <martin.ka...@sweco.se<mailto:martin.ka...@sweco.se>>; geotools-devel@lists.sourceforge.net<mailto:geotools-devel@lists.sourceforge.net> Ämne: Re: [Geotools-devel] Extended life for s3-geotiff in GeoServer, EHCache dependency upgrade I was about to prepare a new list of modules to be decommissioned permanently. s3-geotiff was definitely going to make that list, based on lack of maintainer and that we had reports it stopped working. However, if there is some interest in it, it can be kept, at least for as long as Martin is interested in maintaining it. Cheers Andrea On Mon, May 31, 2021 at 5:56 AM Jody Garnett <jody.garn...@gmail.com<mailto:jody.garn...@gmail.com>> wrote: Thanks Martin: We do require PRs be made gainst main, and then backported. No objection to you taking on s3-geotiff on our end, I caution that I do not think that module has an active developer to review your PR. Indeed we may need to set you up with commit access if you wish to work on a community module, you can see the developers guide<https://urldefense.com/v3/__https:/docs.geoserver.org/latest/en/developer/policies/community-modules.html__;!!HBVxBjZwpQ!moudWjmFbI9ShSyLF33LKmAcIoxajsoIh989BOTe6RnBEmTeHV2bjEttKbnXvFngqDw$> for details. Think about it, and reply to this email with your github id if you are interested in such a role (even for a couple of months while your team transitions to COG). -- Jody Garnett On Sun, 30 May 2021 at 13:23, Kalén, Martin <martin.ka...@sweco.se<mailto:martin.ka...@sweco.se>> wrote: Hi, We have been using GeoServer 2.16.x with s3-geotiff support (in turn supported by GeoTools) in a Docker-image for a customer’s WMS service, recently upgraded to GeoServer 2.19.x where we hit [GEOS-9866]. I have seen that there is a new COG-module in GeoServer, but we need some time to migrate so I have prepared a patch/potential Pull Request against GeoTools for extending the life of s3-geotiff in GeoServer. This was done by upgrading the GeoTools s3-geotiff EHCache-dependency to EHCache v3.0.4 and adjusting the internal caching API accordingly. All unit tests pass and the patched s3-geotiff was tested successfully with GeoServer v2.19.1. I have just signed an individual CLA and gotten confirmation that it’s on file at OSGeo. Any objections against creating a PR against GeoTools v25.x branch? Thanks. Best regards, Martin -- Martin Kalén Senior Consultant Sweco Sweden www.sweco.se<http://www.sweco.se>
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
