Hi, I'm using geotools' unsupported/geobuf with mapbox/geobuf to exchange compressed GeoJSON data, and I found several problems with geotools' geobuf encoding/decoding implementation. mapbox/geobuf is considered the de-facto standard of geobuf so I assume that geotools' unsupported/geobuf should be compatible with mapbox/geobuf.
1. Geobuf written by geotools' unsupported/geobuf can be parsed by mapbox/geobuf, but feature properties were all lost. Geotools' unsupported/geobuf always leave Data.Feature.properties field empty, however this field is mandatory for mapbox/geobuf to parse feature properties. When decoding geobuf, geotools's unsupported/geobuf completely ignores Data.Feature.properties field, this causes problems when one or more properties were missing in some features. 2. Geotools' unsupported/geobuf does not correctly handle negative integers. Negative integer property values encoded by mapbox/geobuf were decoded as positive integer values. My questions are: 1. Is unsupported/geobuf not compatible with mapbox/geobuf by design? 2. I'm glad to submit patches if these problems need to be fixed, do I need to sign the CLA before submitting pull request? Best regards, Kristin Cowalcijk _______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
