Pull requests to get geotools geobuf more compatible with mapbox geobuf would be greatly appreciated.
Jared On Sat, Sep 4, 2021 at 3:01 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > I believe the module is used mainly by GeoScript. I've cc'ed Jared, he's > the main author of GeoScript Groovy, and > also the original contributor of the geobuf module. Let's hear his opinion > :-D > > Cheers > Andrea > > On Sat, Sep 4, 2021 at 10:26 AM Kristin Cowalcijk <moris...@yeah.net> > wrote: > >> Hi, >> >> I'm using geotools' unsupported/geobuf with mapbox/geobuf to exchange >> compressed GeoJSON data, and I found several problems with geotools' >> geobuf >> encoding/decoding implementation. mapbox/geobuf is considered the de-facto >> standard of geobuf so I assume that geotools' unsupported/geobuf should be >> compatible with mapbox/geobuf. >> >> 1. Geobuf written by geotools' unsupported/geobuf can be parsed by >> mapbox/geobuf, but feature properties were all lost. Geotools' >> unsupported/geobuf always leave Data.Feature.properties field empty, >> however >> this field is mandatory for mapbox/geobuf to parse feature properties. >> When >> decoding geobuf, geotools's unsupported/geobuf completely ignores >> Data.Feature.properties field, this causes problems when one or more >> properties >> were missing in some features. >> >> 2. Geotools' unsupported/geobuf does not correctly handle negative >> integers. Negative integer property values encoded by mapbox/geobuf were >> decoded as positive integer values. >> >> My questions are: >> >> 1. Is unsupported/geobuf not compatible with mapbox/geobuf by design? >> 2. I'm glad to submit patches if these problems need to be fixed, do I >> need to >> sign the CLA before submitting pull request? >> >> Best regards, >> Kristin Cowalcijk >> >> >> >> _______________________________________________ >> GeoTools-Devel mailing list >> GeoTools-Devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> > > > -- > > Regards, > > Andrea Aime > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 333 8128928 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail >
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
