Stefan,
Looks great! This will also help make sure users see all the options available in the context menu (specifically, the Excellon file format reloading option which not many people seem to find by themselves). Dan is currently rolling up a 2.5 release, so I'll commit your patches and take a better look at it once we get 2.5 out the door!

Cheers--
Julian

On 01/08/2011 05:45 PM, Stefan Tauner wrote:
Hello again!

i have now implemented the "current layer" menu, i was talking about
in august. it holds the same actions as the layer tree popup menu; the
latter is now just a pointer to this. when there are no files loaded,
it is greyed out and an additional action "toggle visibility" was
added also, which executes the same callback as the visibility
checkboxes in the tree.
the edit menu is now the same as the drawing area popup menu, because i
think that's what most users expect (at least when they right click on
an object. for other cases there should be another menu anyway)
i also moved the "show properties" menu entry to the edit menu for the
same reason.

also attached are two smaller patches that were committed on the way :)
one is cleanup,
the other one fixes a bug in the exit code:
if there are unsaved modifications to the current projects (e.g. deleted
objects) and the user wants to quit gerbv, he gets asked if he is
really sure. previously when the user cancelled, the gui would get
destroyed anyway but the process would not die and lurk in the
background. swallowing the delete-event in the right place fixes this.

this will probably be the last gerbv patch from me (at least for some
time).

git log:
commit 16c7b74631072556e4e98f9a65887d95da5255de
Author: Stefan Tauner<stefan.tau...@student.tuwien.ac.at>
Date:   Sat Jan 8 23:14:16 2011 +0100

     * introduces a new menu "Current Layer" which has the same actions
       as the context menu of the layer tree (actucally those menus ARE
       the same thing).
     * adds "Toggle visibility" to that menu.
     * moves the "show object properties" menu entry from analyze to
       edit.
     * makes the drawing area popup menu identical to the edit menu
       (with currently two actions: "delete" and "show properties")
     * introduces a new method to callbacks.c to show a warning in the
       statusbar when actions are invoked while no files are loaded
       (this also fixes a possible segfault in the "layer up" action)

commit 1c6b9c821545bd2f4f594bb5d8f2ba9b8c02f6ad
Author: Stefan Tauner<stefan.tau...@student.tuwien.ac.at>
Date:   Thu Jan 6 01:24:52 2011 +0100

     change callbacks_quit_activate to swallow the delete-event

commit 37193e90d2ff45dc6d6956508fb221fe9f088bda
Author: Stefan Tauner<stefan.tau...@student.tuwien.ac.at>
Date:   Sat Jan 1 23:39:02 2011 +0100

     minor cleanup (names, variable order) in interface.c





------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to
best implement a security strategy that keeps consumers' information secure
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl


_______________________________________________
Gerbv-devel mailing list
Gerbv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gerbv-devel
------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl 
_______________________________________________
Gerbv-devel mailing list
Gerbv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gerbv-devel

Reply via email to