hello when i said "it will probably take some time" in august, i did not expect to reply now.. in december, sorry.
the first patch is the same as sent in august to change "indeces" to "indices" and to enable the space key to open the layer color picker correctly. your reply back then did not indicate a problem with it, but it is not applied yet. is there something wrong with it? the second one basically adds persistent accelerators, see below for details. if there are any problems, please propose changes you want me to do. changelog for the 2nd patch: - persistent, customizable keyboard accelerators. -- SET_ACCELS* macros to set the defaults more easily. -- ACCEL_* macros to have the default accelerators in one place. -- support for accels of stock items[1]. - new submenus in the view menu for changing rendering type and units. -- synchronizing those with the comboboxes already there was more complicated then i first thought[2]. - GTK_STOCK_* macros instead of constant strings. - GERBV_RENDER_TYPE_* macros instead of constant integers. - removed "callback" from the name of some methods in callback.c and made them static because they are not callbacks. - some minor problems fixed where motivation and perception corresponded :) 1: as documented in interface.h there is a minor problem with my current implementation for the accelerators: the mapping between the gui elements and the key bindings is done with the labels of the menu items. these labels are hardcoded - even for stock items - atm. 2: - the list provided by gtk_radio_menu_item_get_group is reversed (relative to the order of gtk_radio_menu_item_new* called). i was trying to fetch the menu items from that GSList* by indexing into it with the rendering type/display unit with g_slist_nth_data. since the reverse order is not documented anywhere, i set up a GtkCheckMenuItem** by hand now. as long as the gerbv_gui_unit_t stays without holes this should just work. - the change events of the radio button menu items get fired when the buttons are set active programmatically. this is normal for all gtk gui elements afaik, but one needs to guard against infinite recursive event handling. this is done by static gbooleans. it did not work with comparisons of the new value with the current one, dunno why. my solution should work as long as gtk's event code remains single threaded :) -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner
gerbv-interfacepatches2.tar.gz
Description: GNU Zip compressed data
------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________ Gerbv-devel mailing list Gerbv-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gerbv-devel
