hello
regarding the fast aka GERBV_RENDER_TYPE_GDK rendering mode julian said
in bug 3197741
(https://sourceforge.net/tracker/?func=detail&atid=409538&aid=3197741&group_id=33921)
"will be deprecated soon".
if it will... it shouldnt be the default mode in everything != WIN32
imho. :)
on the search for the reason why it defaults to "fast" on my machine i
also noticed a bug in the contribution i made before and some use of
magical numbers...
--
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
>From a59e01e4b9237a489e2ebdf6843e42336f434b55 Mon Sep 17 00:00:00 2001
From: Stefan Tauner <stefan.tau...@student.tuwien.ac.at>
Date: Sat, 5 Mar 2011 19:41:19 +0100
Subject: [PATCH 1/3] make GERBV_RENDER_TYPE_CAIRO_NORMAL default on all plattforms
---
src/main.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/src/main.c b/src/main.c
index d9aa138..04cac44 100644
--- a/src/main.c
+++ b/src/main.c
@@ -346,12 +346,7 @@ main(int argc, char *argv[])
mainProject->execpath = g_path_get_dirname(argv[0]);
/* set default rendering mode */
-#ifdef WIN32
- /* Cairo seems to render faster on Windows, so use it for default */
screenRenderInfo.renderType = GERBV_RENDER_TYPE_CAIRO_NORMAL;
-#else
- screenRenderInfo.renderType = GERBV_RENDER_TYPE_GDK;
-#endif
logToFileOption = FALSE;
logToFileFilename = NULL;
--
1.7.1
>From 2e02f0c7403ee57c4e9e03dbde89406d88c160dc Mon Sep 17 00:00:00 2001
From: Stefan Tauner <stefan.tau...@student.tuwien.ac.at>
Date: Sat, 5 Mar 2011 19:42:35 +0100
Subject: [PATCH 2/3] fix init of view/rendering
---
src/interface.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/interface.c b/src/interface.c
index fdaf6b1..6bd3dda 100644
--- a/src/interface.c
+++ b/src/interface.c
@@ -627,11 +627,11 @@ interface_create_gui (int req_width, int req_height)
screen.win.menu_view_render_group[GERBV_RENDER_TYPE_GDK_XOR] = GTK_CHECK_MENU_ITEM(render_fast_xor);
screen.win.menu_view_render_group[GERBV_RENDER_TYPE_CAIRO_NORMAL] = GTK_CHECK_MENU_ITEM(render_normal);
screen.win.menu_view_render_group[GERBV_RENDER_TYPE_CAIRO_HIGH_QUALITY] = GTK_CHECK_MENU_ITEM(render_hq);
+
+ gtk_check_menu_item_set_active (GTK_CHECK_MENU_ITEM (screen.win.menu_view_render_group[screenRenderInfo.renderType]), TRUE);
}
{ // units submenu
- gtk_check_menu_item_set_active (GTK_CHECK_MENU_ITEM (render_fast), TRUE);
-
menuitem_view_unit = gtk_menu_item_new_with_mnemonic (_("U_nits"));
gtk_container_add (GTK_CONTAINER (menuitem_view_menu), menuitem_view_unit);
--
1.7.1
>From 545c4274738f29bc36d948cd90e03420370c7dc7 Mon Sep 17 00:00:00 2001
From: Stefan Tauner <stefan.tau...@student.tuwien.ac.at>
Date: Sat, 5 Mar 2011 19:44:40 +0100
Subject: [PATCH 3/3] replace magic numbers with macros
---
src/main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/main.c b/src/main.c
index 04cac44..c4daa20 100644
--- a/src/main.c
+++ b/src/main.c
@@ -835,7 +835,8 @@ main(int argc, char *argv[])
gerbv_render_info_t renderInfo = {userSuppliedDpiX, userSuppliedDpiY,
- userSuppliedOriginX, userSuppliedOriginY, userSuppliedAntiAlias?3:2,
+ userSuppliedOriginX, userSuppliedOriginY,
+ userSuppliedAntiAlias?GERBV_RENDER_TYPE_CAIRO_HIGH_QUALITY:GERBV_RENDER_TYPE_CAIRO_NORMAL,
userSuppliedWidth,userSuppliedHeight };
if (exportType == 1) {
--
1.7.1
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
Gerbv-devel mailing list
Gerbv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gerbv-devel
