Patch Set 2: Code-Review-1 actualyl, no. Files in "include/osmocom/" should only be files that are installed into the system. "tests.h" sounds like something only needed during unit tests, and it does not belong into a directory containing system-wide installed header files? Am I missing something?
-- To view, visit https://gerrit.osmocom.org/2075 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I414223f3d9382642fc4f7efb3b35dc950eaaad86 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-HasComments: No
