Patch Set 2: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/2075/2/include/osmocom/tests/conv.h File include/osmocom/tests/conv.h: PS2, Line 3: 512 The max length will cause problems if the output message length of the code is larger than 512 (i.e. MCS-1 and higher codes). -- To view, visit https://gerrit.osmocom.org/2075 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I414223f3d9382642fc4f7efb3b35dc950eaaad86 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Tom Tsou <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-HasComments: Yes
