Patch Set 3: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/2100/3/Transceiver52M/x86/convert.c File Transceiver52M/x86/convert.c: Line 197: if (__builtin_cpu_supports("sse4.1")) { It is only supported by GCC, so building with another compiler, for example with clang, fails: convert.c:197:6: error: use of unknown builtin '__builtin_cpu_supports' [-Wimplicit-function-declaration] if (__builtin_cpu_supports("sse4.1")) { ^ 1 error generated. I don't know, is there any way to determine supported instructions sets in clang, but for now we can go this way: #if (defined(__GNUC__) && !defined(__clang__)) if (__builtin_cpu_supports("sse4.1")) // ... #endif -- To view, visit https://gerrit.osmocom.org/2100 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba74f8a6e4e921ff31e4bd9f0c7c881fe547423a Gerrit-PatchSet: 3 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: Yes
