Patch Set 3: Code-Review-1 > > Do we officially support anything besides gcc? > > not really, but then it is also nice to be portable. My vote would > be to merge the current patch under discussion, but open a ticket > as a reminder that this should be made more portable. I suppose > mplayer/ffmpeg/fftw or other libs with heavily optimized algorithms > also have a solution to that.
As I just figured out, this call is supported in recent clang versions, so IMHO: it would be better don't to break compatibility with older compilers by this commit. It should be fairly easy to add a new configure check whether __builtin_cpu_supports is supported by compiler or not. I'll try to do it in libosmocore. -- To view, visit https://gerrit.osmocom.org/2100 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba74f8a6e4e921ff31e4bd9f0c7c881fe547423a Gerrit-PatchSet: 3 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Alexander Chemeris <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Tom Tsou <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: No
