[MERGED] libosmo-sccp[master]: scu_gen_encode_and_send(): Fix NULL pointer deref

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: scu_gen_encode_and_send(): Fix NULL pointer deref
......................................................................


scu_gen_encode_and_send(): Fix NULL pointer deref

We were using the 'xua' pointer before checkin if it actually is valid

Change-Id: I5cd3250afc0b787b78683cd8ab6b2512e0d5c69e
Fixes: coverity CID#166945
---
M src/sccp_scoc.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c
index 3a52ca6..0eda7ad 100644
--- a/src/sccp_scoc.c
+++ b/src/sccp_scoc.c
@@ -657,8 +657,8 @@
                uconp->calling_addr = conn->calling_addr;
                uconp->sccp_class = conn->sccp_class;
                uconp->importance = conn->importance;
-               data_ie = xua_msg_find_tag(xua, SUA_IEI_DATA);
                if (xua) {
+                       data_ie = xua_msg_find_tag(xua, SUA_IEI_DATA);
                        if (data_ie) {
                                struct msgb *upmsg = scu_prim->oph.msg;
                                upmsg->l2h = msgb_put(upmsg, data_ie->len);

-- 
To view, visit https://gerrit.osmocom.org/2432
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5cd3250afc0b787b78683cd8ab6b2512e0d5c69e
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder