Patch Set 2: Code-Review+1

(2 comments)

How long did the fix take?

https://gerrit.osmocom.org/#/c/2420/2/src/gprs_rlcmac_sched.cpp
File src/gprs_rlcmac_sched.cpp:

Line 186:                       return NULL;
msg is leaked now?


Line 202:               return msg;
okay but we might still have a tbf here?


-- 
To view, visit https://gerrit.osmocom.org/2420
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79f4a945e211a13ac7d1e511cc37b0940ac6202
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Holger Freyther <hol...@freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to