Patch Set 2: (2 comments)
Thanks for the review; the thing is, I don't really know what this code is doing and why, this issue jumped at my knees and now I'm trying to throw stones at it to not be broken. I would very much welcome a more qualified person to take this patch over from me; might be easier than telling me what exactly should happen here, probably in numerous iterations of patch review too. Re how was this found: a live installation of a GSM network saw 80% drop in CS service reliability, hunted down to missing pagings for phones that were using GPRS. In a pcap, before the mentioned patch you see a lot of PACCH pagings, with it you see none. The point being that CS hands down pagings to the PCU in case of GPRS being active, and the regression is that we skip all of those pagings. https://gerrit.osmocom.org/#/c/2420/2/src/gprs_rlcmac_sched.cpp File src/gprs_rlcmac_sched.cpp: Line 186: return NULL; > msg is leaked now? right... Line 202: return msg; > okay but we might still have a tbf here? I kind of assumed that we'd either have a TBF and a message or neither... right, the code is not checking that... -- To view, visit https://gerrit.osmocom.org/2420 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib79f4a945e211a13ac7d1e511cc37b0940ac6202 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
