Patch Set 4: (4 comments)
Thanks for the review! I will collapse the two scripts to one (good point about the sourcing in different directory). Documentation will be added, especially about the "what need the script to provide, which sources osmo-build.sh" topic. The code_style will be changed as well. https://gerrit.osmocom.org/#/c/2465/4/scripts/osmo-artifacts.sh File scripts/osmo-artifacts.sh: Line 5: genericDeps "getBranchAndRevByLocalRepo" > where is genericDeps defined? thanks, will be documented. Line 61: generateArtifactHashes() { > so this function writes various checksums to stdout -- are these just for t Of course, we can decide to only print one checksum. Which one do you prefer? No, they aren't actively used by the script(s) itself, so we can even remove them. But the intention was to provide a possibility to see which artifact has been used on (jenkins build) log level, which may be handy when debugging. Line 70: sleep 1 > why sleep? Good question, afair the 4 [INFO] lines were "splitted" by another log message without the sleep, but I will retest whether it's still - or just has been necessary in a early develop state. https://gerrit.osmocom.org/#/c/2465/4/scripts/osmo-build.sh File scripts/osmo-build.sh: Line 62: buildProject > where is buildProject defined? -- also in the "external" script will be documented, too. -- To view, visit https://gerrit.osmocom.org/2465 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifee0a2f837d23b19aa5326f810234d5452e47484 Gerrit-PatchSet: 4 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: blobb <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: blobb <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
