Patch Set 7: (3 comments)
https://gerrit.osmocom.org/#/c/2465/7/scripts/osmo-build.sh File scripts/osmo-build.sh: Line 86: job_name="${JOB_NAME//\//#}" > Ah, this is a bash-ism that I don't know. My personal preference would be t double-underscores it will be! Thanks for pointing it out. Line 171: rm -f "$job_store/*" > there's also the parallel matrix builds? do they each have a separate artif Yes, each matrix-build axis will have its own artifact store, because each matrix job has a different $JOB_NAME (holds axis-configuration). Line 187: generateArtifactHashes "$1" > let's try to keep the algorithm completely timing-free, i.e. do not rely on True, let's keep it simple! -- To view, visit https://gerrit.osmocom.org/2465 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifee0a2f837d23b19aa5326f810234d5452e47484 Gerrit-PatchSet: 7 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: blobb <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: blobb <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
