Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/2604/1/src/osmo-gsm-tester.py File src/osmo-gsm-tester.py: Line 216: log.log_exn() could it be an issue: if at some early stage before log object is initialized there is an exception, then you go here and it may trigger a new exception when this line is executed, masking the real exception (the failure in this line will be shown instead.) You know better the log code than me, so please have a look if that's possible. In that case, we may want to "try: log.log_exn() except: pass, then raise" -- To view, visit https://gerrit.osmocom.org/2604 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8085318c91b06a3e8f7d3f8cfdd15a99650666e2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
