Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/2604/1/src/osmo-gsm-tester.py File src/osmo-gsm-tester.py: Line 216: log.log_exn() > could it be an issue: if at some early stage before log object is initializ 'pass' would "swallow" the exception, the 'raise' keeps it alive and passes it on to the outer scope. So this is telling the log to show the exception, then carries on to terminate the program with an exception anyway. (Since exceptions within test runs should be caught and evaluated, this is basically about exceptions during command line parsing and such, so it's appropriate to abort immediately. ... hm that would be a good code comment.) -- To view, visit https://gerrit.osmocom.org/2604 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8085318c91b06a3e8f7d3f8cfdd15a99650666e2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
