Patch Set 1: (2 comments)
https://gerrit.osmocom.org/#/c/2668/1/src/host/layer23/include/osmocom/bb/mobile/mncc_sock.h File src/host/layer23/include/osmocom/bb/mobile/mncc_sock.h: Line 13 why not simply use 'inst' as the talloc context? We already have that as an argument, and it seems to be the 'ms' (which is a talloc context)? Am I missing something? https://gerrit.osmocom.org/#/c/2668/1/src/host/layer23/include/osmocom/bb/mobile/subscriber.h File src/host/layer23/include/osmocom/bb/mobile/subscriber.h: Line 102: int gsm_subscr_add_forbidden_plmn(struct gsm_subscriber *subscr, uint16_t mcc, Is there not a 1:1 relationship between subscr and ms, so we can do this without adding 'ms' as argument? -- To view, visit https://gerrit.osmocom.org/2668 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d5fcbdd77fe41d78cfe54731dd2ebfc4171f62c Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-HasComments: Yes
