Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/2668/1/src/host/layer23/include/osmocom/bb/mobile/subscriber.h
File src/host/layer23/include/osmocom/bb/mobile/subscriber.h:

Line 102: int gsm_subscr_add_forbidden_plmn(struct gsm_subscriber *subscr, 
uint16_t mcc,
> Yes, there is. But gsm_subscriber is being allocated
In this case I suggest to first introduce an independent patch that changes 
from static member of osmocom_ms to talloc-allocated gsm_subscriber, and then 
rebase this patch on top of that, using the subscriber as context.


-- 
To view, visit https://gerrit.osmocom.org/2668
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d5fcbdd77fe41d78cfe54731dd2ebfc4171f62c
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-HasComments: Yes

Reply via email to