Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/2670/1/src/osmo_gsm_tester/suite.py File src/osmo_gsm_tester/suite.py: Line 313: finally: > I meant: do you really need to register signal handlers? isn't this 'try:.. The default signal handler (KeyboardInterrupt) doesn't work in all cases. See https://stackoverflow.com/questions/40775054/capturing-sigint-using-keyboardinterrupt-exception-works-in-terminal-not-in-scr/40785230#40785230 On top of that, the KeyboardInterrupt works for SIGINT but it's not used for SIGTERM for instance, which means if you send kill to it you leak resources. -- To view, visit https://gerrit.osmocom.org/2670 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I039e4d1908a04bf606b101ddc6a186ba67e6178e Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: report Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
