Patch Set 2: Code-Review+1 (2 comments)
https://gerrit.osmocom.org/#/c/2670/2/src/osmo-gsm-tester.py File src/osmo-gsm-tester.py: Line 200: except Exception: this is made stricter to not catch SystemExit? because we don't want to delay by writing to a log file? (maybe place a comment) https://gerrit.osmocom.org/#/c/2670/2/src/osmo_gsm_tester/suite.py File src/osmo_gsm_tester/suite.py: Line 269: self.stop_processes() this stops child processes, but how is the resource cleaning ensured? via atexit, right? (could be mentioned in the comment) -- To view, visit https://gerrit.osmocom.org/2670 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I039e4d1908a04bf606b101ddc6a186ba67e6178e Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: report Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
