Patch Set 4:

(3 comments)

https://gerrit.osmocom.org/#/c/2669/4/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:

Line 32:     def __init__(self, fail_type='', fail_msg=''):
> * what exactly is the fail_type? is it junit specific? let's document here,
fail_type is just a keyword to define the type of failure, same as in you have 
types of errors or exceptions. JUNit report makes use of this on the output for 
instance.

I will make the parameters mandatory then.


Line 123:                 fmsg =  e.fail_msg + '\n' + 
traceback.format_exc().rstrip()
> (double space but whatever)
OK


Line 144:     def set_fail(self, fail_type='', fail_message='', tb=True):
> (again require args instead of default-empty?)
OK


-- 
To view, visit https://gerrit.osmocom.org/2669
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedf6d912b3cce3333a187a4ac6d5c6b70fe9d5c5
Gerrit-PatchSet: 4
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to