Patch Set 7: (3 comments)
https://gerrit.osmocom.org/#/c/2669/7/src/osmo_gsm_tester/suite.py File src/osmo_gsm_tester/suite.py: Line 109: self.fail_message = '' > set these to None instead? Done Line 151: self.duration = round(time.time() - self.start_timestamp) > you are rounding because...? for cosmetic reasons? Rather ceil() so we don' JUNit supports only an integer value for this. I'll keep the float here and do the int conversion in the JUNit specific code. Line 186: def clear_test_vars(self): > still '_test_vars' sounds like it is related to the environment for a test - About naming: as I already said, I like the current or the previous name, but I'll again change it if you like it more as 'mark_start()'. - Better not move into __init__ because we still want to return the status code. - I call this function during __init__ to just in case at some point someone decides to print the SuiteRun (or write a report) or get status or whatever before running the test. Anyway, I will remove it. -- To view, visit https://gerrit.osmocom.org/2669 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedf6d912b3cce3333a187a4ac6d5c6b70fe9d5c5 Gerrit-PatchSet: 7 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
