Patch Set 8: (2 comments)
https://gerrit.osmocom.org/#/c/2412/8/src/common/measurement.c File src/common/measurement.c: Line 229: } else { I don't think we use empty-else-with-comment style anywhere else. Just the comment would be enough. Line 238: /*Do Nothing */ Same here except that "do nothing" comment does not have much value. -- To view, visit https://gerrit.osmocom.org/2412 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e0dfd13b53e8aa2822985f12bf2985e683ab553 Gerrit-PatchSet: 8 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
