Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/2412/1/src/common/measurement.c File src/common/measurement.c: Line 210: "Update TA TimingOffset_Mean:%d, UL RX TA:%d, DL ordered TA:%d, flags:%d \n", log statements here must include some kind of prefix for the lchan, otherwise you cannot know about which lchan they are logging information. We have gsm_lchan_name() for that, and it is used in other places. -- To view, visit https://gerrit.osmocom.org/2412 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e0dfd13b53e8aa2822985f12bf2985e683ab553 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
