Patch Set 2: Code-Review-1 (2 comments)
https://gerrit.osmocom.org/#/c/2854/2/src/osmo_gsm_tester/report.py File src/osmo_gsm_tester/report.py: Line 64: else: what if test is Test.PASS ? it falls here right? which is wrong I guess. You probably want to check for UNKNOWN. Line 65: error = et.SubElement(testcase, 'error') I think I preferred how the output was done before these changes. If the suite run failed in the middle of running tests, then the remaining tests simply didn't show in the xml, and the 'tests' counter in the 'testsuite' node was smaller. When showing that in the graph in jenkins, you easily see less tests were run at that time, which is different than failing. -- To view, visit https://gerrit.osmocom.org/2854 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a334ef3463896c543c0fe592d3903c15e67d4c4 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
