Patch Set 5: (2 comments)
https://gerrit.osmocom.org/#/c/2854/5/src/osmo_gsm_tester/suite.py File src/osmo_gsm_tester/suite.py: Line 212: try: As we are no longer returning the status from here, I think it would be a good idea to state in the method documentation that the result of the method can be found in the "status" property of the instance. Line 222: try: Did you move all this code from Test.run to here to avoid having issues with order of "try" and "with"? Let's say this is at least ugly. Unless you have a good reason for doing this here, I think it should be inside test.run(). -- To view, visit https://gerrit.osmocom.org/2854 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a334ef3463896c543c0fe592d3903c15e67d4c4 Gerrit-PatchSet: 5 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
