Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/2852/1/src/osmo_gsm_tester/resource.py File src/osmo_gsm_tester/resource.py: Line 483: msg = 'suite.conf reserved only %d x %r.' % (len(kind_reserved), kind) > Can this case happen? can we end up using more resources than the ones we r yes. If we reserved 4 modems in suite.conf, we can call suite.modem() four times. At that point used_count becomes == len(kind_reserved). If then we call suite.modem() a fifth time, this code path hits. I tested it manually. -- To view, visit https://gerrit.osmocom.org/2852 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c67600ba69351859e46b8b2f368ee8106db0993 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
