Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/2852/1/src/osmo_gsm_tester/resource.py File src/osmo_gsm_tester/resource.py: Line 483: msg = 'suite.conf reserved only %d x %r.' % (len(kind_reserved), kind) > Are you perhaps checking the wrong way or I am missing something here? I'm exactly, this is correct. I could check for used_count == len(), but my personal preference is to write more paranoid code. What if for some odd software bug, used_count ends up > len()? Hence I rather check for "not (used_count < len())". Also IMHO this clarifies what I usually want: used_count to be smaller than the reserved amount. If it's not smaller, then go to this error case. -- To view, visit https://gerrit.osmocom.org/2852 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c67600ba69351859e46b8b2f368ee8106db0993 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
