Patch Set 5: Code-Review+2 (2 comments)
If you can find a way to move back the exception code inside test.run() please do, otherwise you can merge. https://gerrit.osmocom.org/#/c/2853/2/selftest/suite_test.py File selftest/suite_test.py: Line 33: results = s.run_tests('test_error.py') > by printing the output, all of it is verified in the suite_test.ok file Good point thanks https://gerrit.osmocom.org/#/c/2853/5/src/osmo_gsm_tester/suite.py File src/osmo_gsm_tester/suite.py: Line 222: except Exception as e: As I said on the other patch, moving this here seems ugly, but if there's not better way we can keep it here for now. -- To view, visit https://gerrit.osmocom.org/2853 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf0846d457cab26f54c25e6906a8bb304724e2d8 Gerrit-PatchSet: 5 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
