Patch Set 5: (1 comment)
https://gerrit.osmocom.org/#/c/2853/5/src/osmo_gsm_tester/suite.py File src/osmo_gsm_tester/suite.py: Line 222: except Exception as e: > As I said on the other patch, moving this here seems ugly, but if there's n either we have the 'with self' in test.run(), or we have the exception handling here. Moving the code is not optimal, but it unifies the way we do this across the several layers of trial, suite, test. -- To view, visit https://gerrit.osmocom.org/2853 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf0846d457cab26f54c25e6906a8bb304724e2d8 Gerrit-PatchSet: 5 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
