Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/2857/1/include/osmocom/core/utils.h File include/osmocom/core/utils.h: Line 24: #define OSMO_SET(x, flag) ((x) |= 1 << (flag)) I'd add _BIT_ to all of them, otherwise seems a bit too generic and you don't know what's doing at first glance: OSMO_BIT_SET() -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
