Patch Set 3: Code-Review-1 I'm not sure if this is really useful. Actually, to me, you are hiding what the code does. Every c programmer knows what "foo & (1 << bit)" means. By introducing "non-standard" syntax for such basic operations, I think you're actually making code harder to read. With that kind of argument, we could also be adding macros like OSMO_INC(x) instead of "x += 1" ...
-- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-HasComments: No
